Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add new block inline with subsites #526

Closed
robbieaverill opened this issue Nov 27, 2018 · 6 comments
Closed

Cannot add new block inline with subsites #526

robbieaverill opened this issue Nov 27, 2018 · 6 comments

Comments

@robbieaverill
Copy link
Contributor

Version: CWP 2.2.x-dev

  • Create some subsites
  • Switch to a subsite that isn't "Main site"
  • Create a new Blocks Page
  • Try to add a content block to it

Expected: should add a new content block

Actual: nothing happens

GraphQL response returns successfully (it would seem) but with no records in it.

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Nov 27, 2018

If I don't use the elemental subsites compatibility module it works fine for me. I'm not sure what the compatibility module is doing to be honest. It's putting SubsiteID on BaseElement but I don't understand why? We have an area per page which'll sort Subsites I think?

@robbieaverill
Copy link
Contributor Author

I'm not really sure either. I think it's there to support the elemental-virtual module functionality, where you could use a block on multiple pages via an unversioned many many. Since SilverStripe Ltd doesn't support that module, perhaps we could remove the subsites compatibility module from the content blocks recipe and CWP kitchen sink, and add a note to the virtual module suggesting you install the subsites compat module if using virtual elements on a project with subsites

@ScopeyNZ
Copy link
Contributor

Yeah I didn't get a chance to check out that module today or play around with this some more to figure out its purpose. I'll try to get some time before the beginning of next week.

Otherwise I agree with removing it. Currently it works better without it than with it (in the context of subsites).

@rupachup rupachup modified the milestones: Sprint 25, Sprint 26 Nov 28, 2018
@brynwhyman
Copy link

brynwhyman commented Dec 4, 2018

Given that initial investigations seem to imply that this issue is being caused by the dnadesign/silverstripe-elemental-subsites module; or rather that subsites and elemental are compatible without the inclusion of this module, I'm inclined to reduce the impact to medium. Let me know if someone disagrees.

dnadesign/silverstripe-elemental-subsites already isn't included in the silverstripe/recipe-content-blocks recipe, so no need to remove it. We should confirm that it's sole purpose is to support the elemental-virtual module functionality. I'll raise an issue within that repo to capture that.

Edit: investigation issue captured here: dnadesign/silverstripe-elemental-subsites#7

@robbieaverill
Copy link
Contributor Author

Cool - so then our fix for this issue is largely internal, and would amount to removing the module from the CWP kitchen sink

@ScopeyNZ ScopeyNZ removed their assignment Dec 4, 2018
@robbieaverill
Copy link
Contributor Author

We've removed it from the recipe - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants