You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You can see in the above CI job that commit f31d851 of silverstripe/session-manager is being used. You can also see lastpass but let's not talk about that..
I'd expect a type exception given that SilverStripe\SessionManager\Model\LoginSession does not exist in silverstripe/session-manager at commit f31d851.
Might be something, might not 🤷🏻♂️ 😀
I only briefly glanced at this list but it sounds like some of these are genuine bugs - are there issues for them?
@GuySartorelli CC since I think this is what you were asking for (splitting out from #53)?
The text was updated successfully, but these errors were encountered:
LiamKearn
changed the title
Session manager namespaces are seemingly incorrect
Session manager - namespaces are seemingly incorrect
Jun 16, 2023
Looking at this commit of auditor: https://github.com/silverstripe/silverstripe-auditor/tree/3e7365cc746000762c08c292f140b2f46df20922
And it's CI job with silverstripe/session-manager installed: https://github.com/silverstripe/silverstripe-auditor/actions/runs/4878200297/jobs/8703966002
You can see in the above CI job that commit f31d851 of silverstripe/session-manager is being used. You can also see lastpass but let's not talk about that..
In commit f31d851 a
LoginSession
is under the namespaceSilverStripe\SessionManager\Models
however in the commit in this module that triggered the run LoginSession is used as a parameter type hint and referred to asSilverStripe\SessionManager\Model\LoginSession
(Model not Models).I'd expect a type exception given that
SilverStripe\SessionManager\Model\LoginSession
does not exist in silverstripe/session-manager at commit f31d851.Might be something, might not 🤷🏻♂️ 😀
@GuySartorelli CC since I think this is what you were asking for (splitting out from #53)?
The text was updated successfully, but these errors were encountered: