check temp path before deleting files in __destruct to avoid Object Injection #664
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #663
Manual testing steps
You can test this manually via cli in various ways, or by doing something crude like adding this to the end of the main index.php
This simulates a PHP Object Injection vulnerability.
You can then pass the payload as a query param, and check whether the target file has been deleted.
e.g. here's a urlencoded payload to remove a test file called now_you_see_me.txt in the docroot:
Issues
Pull request checklist