Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Add deprecation #650

Merged
merged 1 commit into from
Oct 20, 2024
Merged

API Add deprecation #650

merged 1 commit into from
Oct 20, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Oct 15, 2024
Closed
10 tasks
GuySartorelli
GuySartorelli requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're not introducing the new method here as an alias, so people can swap directly to it before the major upgrade?

@emteknetnz emteknetnz force-pushed the pulls/2/field-validator-depr branch from fda3b9d to c947166 Compare October 20, 2024 22:02
@emteknetnz
Copy link
Member Author

Good point, have updated

@emteknetnz emteknetnz force-pushed the pulls/2/field-validator-depr branch from c947166 to 908c59b Compare October 20, 2024 22:48
GuySartorelli
GuySartorelli approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit b6b78b3 into silverstripe:2 Oct 20, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/field-validator-depr branch October 20, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli