Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Use Symfony's Path class #643

Closed
wants to merge 1 commit into from
Closed

API Use Symfony's Path class #643

wants to merge 1 commit into from

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Sep 13, 2024
Closed
2 tasks
GuySartorelli
GuySartorelli commented Sep 13, 2024
View reviewed changes
src/FilenameParsing/AbstractFileIDHelper.php
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for path traversal protection anywhere here because if an attacker can manipulate these paths they already control either your server or your codebase.

@GuySartorelli GuySartorelli deleted the pulls/3/symfony-path branch September 18, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GuySartorelli