FIX Respect strict-typing of Factory interface #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Jul 11, 2024
| @@ -35,7 +35,7 @@ public function __construct(Factory $creator) | |||
| * @param array $params The constructor parameters. | |||
| * @return object The created service instances. | |||
| */ | |||
| public function create($service, array $params = []) | |||
| public function create(string $service, array $params = []): ?Image_Backend | |||
There was a problem hiding this comment.
See lines 58 on - if the file is missing, null is returned.
emteknetnz
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respects the new strict typing in silverstripe/silverstripe-framework#11300
That PR is required for Ci to go green.
Issue