New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileIDHelperResolutionStrategy::findVariants() ordering issue #534

Open

emteknetnz opened this issue Dec 15, 2022 · 0 comments

Labels

affects/v5 complexity/medium impact/medium type/bug

Member

emteknetnz commented Dec 15, 2022 •

edited

Loading

findVariants() seems to be having some issue with the order of results returned

This was first noticed in 3495084#diff-0668b7adbf9e875b66c47d35627b4ed054921175c1c8583e407607e4c4629353R526 where the order was changed

I experienced it again locally, and fixed this unit test to be order agnostic #535

Investigate to see if this is something that we should even be worried about, and if there's a fix

The text was updated successfully, but these errors were encountered:

emteknetnz mentioned this issue

MNT Make asset variant unit tests order agnostic #535

Merged

emteknetnz added type/bug complexity/medium impact/medium affects/v5 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment