-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an image-conversion module #490
Comments
How is "suitable" defined? Can developers choose what is "suitable" for their project? e.g. maybe the default is white, but they have a primarily dark-mode website so they want to use some off-black instead? |
I don't understand the reasoning behind this? If we're defining the API for converters in core, it seems to make sense that some sensible default converters such as defined here should also ship in core? |
Shipping it in an optional module, allows us to not worry about the API too much and to change it later. If we are super happy with the end results, maybe we fold it back into core later.
My main concern here, is what happens when a user uploads a WebP with some transparency? Does your system need to be smart enough do know that the fall back should be a PNG because of the transparency? |
I thought the API is being defined in core via #489? |
A lot of this is covered by #489 which adds a image-to-image converter powered by intervention image. |
I'll move this back to backlog. Let's live with the feature as implemented for now. If we find that the other things are needed, we can revisit. |
As a developer, I want the ability to seamlessly convert images between formats.
Acceptance criteria
Notes
Excludes
The text was updated successfully, but these errors were encountered: