Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Update GitHub labels #29

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jan 25, 2024

Issue silverstripe/.github#154

Have tested this to update labels for config + siteconfig

Have also tested it to rename, change color and delete labels

The rename + change color + delete functionality was copied over from previous work done in https://github.com/emteknetnz/issue-relabeller/blob/main/run.php - it's very useful and simple to add so added in this PR.

Will update labels in all other supported repos once this PR is approved and merged. I'll do a dry-run first and then do it for real once I've validated that I won't accidentally delete a bunch of existing labels

@emteknetnz emteknetnz force-pushed the pulls/main/labels branch 2 times, most recently from dcee893 to 3905eb3 Compare January 25, 2024 23:17
@emteknetnz emteknetnz marked this pull request as ready for review January 25, 2024 23:18
funcs_utils.php Outdated Show resolved Hide resolved
run.php Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/main/labels branch 3 times, most recently from 6262c49 to a170523 Compare January 25, 2024 23:38
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By-and-large looks good, just a few small things

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
funcs_utils.php Outdated Show resolved Hide resolved
funcs_utils.php Outdated Show resolved Hide resolved
labels_command.php Outdated Show resolved Hide resolved
labels_command.php Show resolved Hide resolved
labels_command.php Show resolved Hide resolved
labels_command.php Show resolved Hide resolved
labels_command.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/main/labels branch 2 times, most recently from 7a63a83 to 974db45 Compare January 26, 2024 02:43
@GuySartorelli
Copy link
Member

#29 (comment)
Still not done

@emteknetnz
Copy link
Member Author

Updated

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit f2a67c6 into silverstripe:main Jan 26, 2024
1 check passed
@GuySartorelli GuySartorelli deleted the pulls/main/labels branch January 26, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants