-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Update GitHub labels #29
Merged
GuySartorelli
merged 1 commit into
silverstripe:main
from
creative-commoners:pulls/main/labels
Jan 26, 2024
Merged
NEW Update GitHub labels #29
GuySartorelli
merged 1 commit into
silverstripe:main
from
creative-commoners:pulls/main/labels
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
force-pushed
the
pulls/main/labels
branch
2 times, most recently
from
January 25, 2024 23:17
dcee893
to
3905eb3
Compare
emteknetnz
commented
Jan 25, 2024
emteknetnz
commented
Jan 25, 2024
emteknetnz
commented
Jan 25, 2024
emteknetnz
force-pushed
the
pulls/main/labels
branch
3 times, most recently
from
January 25, 2024 23:38
6262c49
to
a170523
Compare
GuySartorelli
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By-and-large looks good, just a few small things
emteknetnz
force-pushed
the
pulls/main/labels
branch
from
January 26, 2024 02:03
a170523
to
8b286f5
Compare
GuySartorelli
requested changes
Jan 26, 2024
emteknetnz
force-pushed
the
pulls/main/labels
branch
2 times, most recently
from
January 26, 2024 02:43
7a63a83
to
974db45
Compare
#29 (comment) |
emteknetnz
force-pushed
the
pulls/main/labels
branch
from
January 26, 2024 02:59
974db45
to
1258cf4
Compare
Updated |
GuySartorelli
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#154
Have tested this to update labels for config + siteconfig
Have also tested it to rename, change color and delete labels
The rename + change color + delete functionality was copied over from previous work done in https://github.com/emteknetnz/issue-relabeller/blob/main/run.php - it's very useful and simple to add so added in this PR.
Will update labels in all other supported repos once this PR is approved and merged. I'll do a dry-run first and then do it for real once I've validated that I won't accidentally delete a bunch of existing labels