Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook retry #532

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Webhook retry #532

merged 2 commits into from
Oct 31, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 31, 2024 •
edited by ddaspit
Loading

#530

This change is Reviewable

@johnml1135 johnml1135 requested a review from Enkidu93 October 31, 2024 20:59
Enkidu93
Enkidu93 reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Trusting you've verified this works as expected. Is there no way to do this with Polly?

Reviewable status: 0 of 4 files reviewed, all discussions resolved

@johnml1135
Copy link
Collaborator Author

Hangfire already had a "retry" mechanism built in. They were both enabled - and the Hangfire one is more straightforward than the Polly one.

@johnml1135 johnml1135 merged commit 4d4b013 into main Oct 31, 2024
2 of 3 checks passed
@johnml1135 johnml1135 deleted the webhook_retry branch October 31, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enkidu93 Enkidu93 Enkidu93 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnml1135 @Enkidu93