Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Word Alignment engine: #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Word Alignment engine: #506

wants to merge 1 commit into from

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Oct 9, 2024

  • Add HTTP API
  • Add Grpc
  • Add Echo
  • Add Serval services
  • Add machine level implementation
  • Add tests

This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit October 9, 2024 16:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 42.23790% with 1146 lines in your changes missing coverage. Please review.

Project coverage is 51.31%. Comparing base (a68bc9c) to head (6987a7a).

Files with missing lines Patch % Lines
...ment/Controllers/WordAlignmentEnginesController.cs 0.00% 405 Missing ⚠️
...red/Services/ServalWordAlignmentEngineServiceV1.cs 0.00% 144 Missing ⚠️
...achine.Shared/Services/StatisticalEngineService.cs 0.00% 121 Missing ⚠️
...src/Serval.WordAlignment/Services/EngineService.cs 73.97% 94 Missing and 14 partials ⚠️
...hine.Shared/Services/TranslationBuildJobService.cs 0.00% 42 Missing ⚠️
...l.Machine.Shared/Services/ClearMLMonitorService.cs 11.90% 37 Missing ⚠️
...ignment/Services/WordAlignmentPlatformServiceV1.cs 88.39% 21 Missing and 13 partials ⚠️
...ks/Consumers/WordAlignmentBuildFinishedConsumer.cs 0.00% 29 Missing ⚠️
...oks/Consumers/WordAlignmentBuildStartedConsumer.cs 0.00% 26 Missing ⚠️
...l.WordAlignment/Contracts/WordAlignmentBuildDto.cs 0.00% 15 Missing ⚠️
... and 38 more

❗ There is a different number of reports uploaded between BASE (a68bc9c) and HEAD (6987a7a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a68bc9c) HEAD (6987a7a)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   57.25%   51.31%   -5.95%     
==========================================
  Files         299      342      +43     
  Lines       15664    18957    +3293     
  Branches     2163     2678     +515     
==========================================
+ Hits         8968     9727     +759     
- Misses       6054     8558    +2504     
- Partials      642      672      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135 johnml1135 force-pushed the word_alignment_try_2 branch 3 times, most recently from b547740 to f72b568 Compare October 14, 2024 16:58
@johnml1135 johnml1135 force-pushed the word_alignment_try_2 branch from 82c30fe to da20548 Compare October 24, 2024 19:38
@johnml1135 johnml1135 force-pushed the word_alignment_try_2 branch 4 times, most recently from 41d48d1 to 9b268f2 Compare November 6, 2024 16:00
@johnml1135
Copy link
Collaborator Author

@ddaspit - this is finally ready for review.

@johnml1135 johnml1135 force-pushed the word_alignment_try_2 branch 2 times, most recently from c760b43 to 70810a7 Compare November 12, 2024 20:03
@johnml1135 johnml1135 force-pushed the word_alignment_try_2 branch 2 times, most recently from c918168 to 0b9c983 Compare December 9, 2024 17:37
* Add HTTP API
* Add Grpc
* Add Echo (as single engine)
* Add Serval services
* Add webhooks
* Update docker-compose
* Basic echo works
* Machine Engine updates are made
* Add Word Alignment tests
* Fix Translation Engine - parallel corpus both TextIds and ScriptureRange should cause an * Use matching machine branch for CI tests
* Update to MongoDB 8.0
* Add new word alignment platform pipeline
* Add some integration tests (broken)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants