Add open telemetry

[Enkidu93]

Fixes #58

---

This change is 

[ddaspit]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Enkidu93 and @johnml1135)

---

src/Serval.ApiServer/Startup.cs line 163 at r1 (raw file):

        services
            .AddOpenTelemetry()
            .WithTracing(builder =>

We also want gRPC instrumentation.

---

src/Serval.ApiServer/Startup.cs line 165 at r1 (raw file):

            .WithTracing(builder =>
            {
                builder.AddAspNetCoreInstrumentation().AddConsoleExporter();

You only need to call AddConsoleExporter() once. The convention in ASP.NET Core is to return the builder instance on each method that adds a service, this allows you to chain the methods:

builder
    .AddAspNetCoreInstrumentation()
    .AddHttpClientInstrumentation()
    .AddSource("MongoDB.Driver.Core.Extensions.DiagnosticSources")
    .AddConsoleExporter();

[johnml1135]

src/Serval.ApiServer/Serval.ApiServer.csproj line 27 at r1 (raw file):

		<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.6.0" />
		<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.5.1-beta.1" />
		<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.5.1-beta.1" />

Why are we adding package references instead of installing it in the docker images as in here: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/tree/main/examples/demo? There could be great reasons - I just don't know them.

[Enkidu93]

src/Serval.ApiServer/Serval.ApiServer.csproj line 27 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Why are we adding package references instead of installing it in the docker images as in here: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/tree/main/examples/demo? There could be great reasons - I just don't know them.

I'm not sure I understand the question entirely, but I think you're referencing the use of the OpenTelemetry Collector (?). These imports are for the automatic instrumentation. Right now we're exporting to the console (not a good long-term solution probably). If we wanted to add a collector, that's doable but a separate issue I think. See this for more information.

[Enkidu93]

src/Serval.ApiServer/Startup.cs line 165 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

You only need to call AddConsoleExporter() once. The convention in ASP.NET Core is to return the builder instance on each method that adds a service, this allows you to chain the methods:

builder
    .AddAspNetCoreInstrumentation()
    .AddHttpClientInstrumentation()
    .AddSource("MongoDB.Driver.Core.Extensions.DiagnosticSources")
    .AddConsoleExporter();

Yes, I apologize. The example I followed made that mistake, and although it didn't make sense to me, I sheeped along. I'll fix that.

[ddaspit]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)

[Enkidu93]

@johnml1135 Do you want this to be merged or would you rather I put the console exporter behind a development flag first?

[Enkidu93]

Dismissed @johnml1135 from a discussion.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @ddaspit and @johnml1135)

---

src/Serval.ApiServer/Startup.cs line 163 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

We also want gRPC instrumentation.

Oh, good catch - sorry!

[johnml1135]

src/Serval.ApiServer/Serval.ApiServer.csproj line 27 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

I'm not sure I understand the question entirely, but I think you're referencing the use of the OpenTelemetry Collector (?). These imports are for the automatic instrumentation. Right now we're exporting to the console (not a good long-term solution probably). If we wanted to add a collector, that's doable but a separate issue I think. See this for more information.

Let's kick the can - here is the issue: #138

[johnml1135]

Reviewed 4 of 6 files at r1, 1 of 2 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved