Fixes E2E tests failing in CI #109

[Enkidu93]

• Fixes small typo in Echo pretranslation E2E test.
• Adds workflow_dispatch option to ci-e2e.
• (Also, adds .history* to gitignore).

---

This change is 

[ddaspit]

As a part of this PR, could you move the ServalClientHelper class to the Serval.E2ETests assembly. That class is only being used for E2E tests and probably needs a little more work before it is released as part of the Serval.Client library.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)

---

tests/Serval.E2ETests/ServalApiTests.cs line 71 at r1 (raw file):

    {
        await _helperClient.ClearEngines();
        string engineId = await _helperClient.CreateNewEngine("Echo", "es", "es", "Echo2");

I think the cause of this issue is that the EnginePerUser dictionary is not cleared in the ClearEngines method.

[johnml1135]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

[Enkidu93]

Done

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)

---

tests/Serval.E2ETests/ServalApiTests.cs line 71 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

I think the cause of this issue is that the EnginePerUser dictionary is not cleared in the ClearEngines method.

I added a call to Clear(). I also switched to using the SetUp function rather a constructor because I believe it's more stylistically sound, is more consistent with other tests, and because, as I understand it, it guarantees that each test is unaffected by the other tests if they're run concurrently.

[ddaspit]

Everything looks good. You forgot to remove the ServalClientHelper class from the Serval.Client assembly.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

[johnml1135]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

[johnml1135]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

[Enkidu93]

Everything looks good. You forgot to remove the ServalClientHelper class from the Serval.Client assembly.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Sorry, somehow it didn't commit even though I had changed it locally and hit the save/commit all and push button. It's done now (I think 😆 ).

[johnml1135]

[ddaspit]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

[johnml1135]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

[johnml1135]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)