refactored code to reflect suggestions

src/Serval/src/Serval.ApiServer/appsettings.json

@@ -14,8 +14,5 @@
     "LogLevel": {
       "System.Net.Http.HttpClient": "Warning"
     }
-  },
-  "ServalSettings": {
-    "ReleaseVersion": "1.0.0"
   }
 }

src/Serval/src/Serval.Translation/Controllers/TranslationEnginesController.cs

@@ -1047,9 +1047,12 @@ public async Task<ActionResult<TranslationBuildDto>> StartBuildAsync(
         CancellationToken cancellationToken
     )
     {
+        string deploymentVersion = configuration.GetValue<string>("deploymentVersion") ?? "Unknown";
+
         Engine engine = await _engineService.GetAsync(id, cancellationToken);
         await AuthorizeAsync(engine);
-        Build build = Map(engine, buildConfig);
+        Build build = Map(engine, buildConfig, deploymentVersion);
+
         await _engineService.StartBuildAsync(build, cancellationToken);
 
         TranslationBuildDto dto = Map(build);
@@ -1312,10 +1315,8 @@ private Engine Map(TranslationEngineConfigDto source)
         };
     }
 
-    private Build Map(Engine engine, TranslationBuildConfigDto source)
+    private static Build Map(Engine engine, TranslationBuildConfigDto source, string deploymentVersion)
     {
-        string deploymentVersion = configuration.GetValue<string>("DeploymentVersion") ?? "Unknown";
-
         return new Build
         {
             EngineRef = engine.Id,

src/Serval/test/Serval.ApiServer.IntegrationTests/TranslationEngineTests.cs

@@ -2035,7 +2035,7 @@ public void TearDown()
         _env.Dispose();
     }
 
-    public class TestEnvironment : DisposableBase
+    private class TestEnvironment : DisposableBase
     {
         private readonly IServiceScope _scope;
         private readonly MongoClient _mongoClient;