Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement corpus operators supported by ParallelTextCorpus for NParallelTextCorpus #272

Open
Enkidu93 opened this issue Nov 13, 2024 · 3 comments
Open

Implement corpus operators supported by ParallelTextCorpus for NParallelTextCorpus #272

Enkidu93 opened this issue Nov 13, 2024 · 3 comments
Assignees
@Enkidu93

Comments

@Enkidu93
Copy link
Collaborator

No description provided.

@Enkidu93 Enkidu93 self-assigned this Nov 13, 2024
@Enkidu93 Enkidu93 added this to Serval Nov 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Serval Nov 13, 2024
@Enkidu93 Enkidu93 mentioned this issue Nov 13, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Serval Dec 4, 2024
@Enkidu93
Copy link
Collaborator Author

Enkidu93 commented Dec 4, 2024

Where was this completed, @johnml1135 ? This involves adding new methods to the CorpusExtensions in parallel with those that exist for ParallelTextCorpus and was not part of my NParallelTextCorpus PR.

@ddaspit ddaspit reopened this Dec 4, 2024
@ddaspit ddaspit removed this from Serval Dec 4, 2024
@johnml1135
Copy link
Collaborator

My fault - I thought that it was already done. Is this needed for anything? We are currently doing operations on arrays of corpora rather than using NParrallelTextCorpus directly. Therefore, are the corpus extensions needed?

@Enkidu93
Copy link
Collaborator Author

Enkidu93 commented Dec 4, 2024

My fault - I thought that it was already done. Is this needed for anything? We are currently doing operations on arrays of corpora rather than using NParrallelTextCorpus directly. Therefore, are the corpus extensions needed?

No worries. I don't think any of these are things we'd actively need to use, but Damien wanted them in there more for completeness sake/for non-Serval use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enkidu93 Enkidu93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ddaspit @johnml1135 @Enkidu93