You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently most of the update APIs use the parameter order (before, after), but there are some that have the order (after, before). Since these parameters are the same type the compiler won't be able to catch it if we accidentally call them with (before, after) and we'll get runtime bugs where an update gets applied in the "wrong direction". We should make the update APIs consistent so that any APIs that take (before, after) or (old, new) parameters always take them in the same order.
The text was updated successfully, but these errors were encountered:
Currently #1267 is still outstanding, so I'd like to wait until it's merged before tackling this. That way we'll minimize the chances of bugs being introduced by merge conflict resolutions.
Currently most of the update APIs use the parameter order (before, after), but there are some that have the order (after, before). Since these parameters are the same type the compiler won't be able to catch it if we accidentally call them with (before, after) and we'll get runtime bugs where an update gets applied in the "wrong direction". We should make the update APIs consistent so that any APIs that take (before, after) or (old, new) parameters always take them in the same order.
The text was updated successfully, but these errors were encountered: