Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/introduce-object-adapters #15

Merged
merged 14 commits into from
Oct 15, 2024
Merged

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Oct 9, 2024

this allows us to avoid our data models taking a dependency on Harmony. In FW Lite, we were extending our model classes in order to implement the interface, this change will let us avoid that and just define an adapter instead

@hahn-kev hahn-kev requested a review from myieye October 9, 2024 05:28
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Very cool change! 😎 👏

src/SIL.Harmony/CrdtConfig.cs Show resolved Hide resolved
src/SIL.Harmony/CrdtConfig.cs Show resolved Hide resolved
src/SIL.Harmony/Db/CrdtRepository.cs Outdated Show resolved Hide resolved
@hahn-kev hahn-kev enabled auto-merge (squash) October 15, 2024 02:24
@hahn-kev hahn-kev merged commit 4200fa1 into main Oct 15, 2024
2 checks passed
@hahn-kev hahn-kev deleted the chore/introduce-object-adapters branch October 15, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants