From b1a1041cae0f5d8607ed924152434ce559b86b3e Mon Sep 17 00:00:00 2001 From: Kevin Hahn Date: Tue, 29 Oct 2024 11:57:39 +0700 Subject: [PATCH] only comment when there's an alert, make performance good again --- .github/workflows/test.yaml | 3 +-- src/SIL.Harmony.Tests/DataModelPerformanceTests.cs | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 352dfb8..e13030e 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -33,7 +33,6 @@ jobs: output-file-path: src/artifacts/bin/SIL.Harmony.Tests/release/BenchmarkDotNet.Artifacts/results/SIL.Harmony.Tests.DataModelPerformanceBenchmarks-report-full-compressed.json external-data-json-path: ./cache/benchmark-data.json fail-on-alert: true - summary-always: true - comment-always: true + comment-on-alert: true github-token: ${{ secrets.GITHUB_TOKEN }} \ No newline at end of file diff --git a/src/SIL.Harmony.Tests/DataModelPerformanceTests.cs b/src/SIL.Harmony.Tests/DataModelPerformanceTests.cs index 6c8d5fa..e53bb92 100644 --- a/src/SIL.Harmony.Tests/DataModelPerformanceTests.cs +++ b/src/SIL.Harmony.Tests/DataModelPerformanceTests.cs @@ -203,7 +203,7 @@ public void GlobalSetup() [IterationSetup] public void IterationSetup() { - _emptyDataModel = new(alwaysValidate: false, performanceTest: false); + _emptyDataModel = new(alwaysValidate: false, performanceTest: true); _ = _emptyDataModel.WriteNextChange(_emptyDataModel.SetWord(Guid.NewGuid(), "entity1")).Result; _dataModelTestBase = _templateModel.ForkDatabase(false); }