Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntries] Cannot save entries without gloss even with definition #3469

Open
imnasnainaec opened this issue Dec 5, 2024 · 0 comments
Open
Labels
bug Something isn't working frontend goal: ReviewEntries Size: S Small sized issue

Comments

@imnasnainaec
Copy link
Collaborator

imnasnainaec commented Dec 5, 2024

In review entries, we intentionally don't allow entries to be saved without a gloss. (There's an exception is for protected entries, since they cannot be deleted.) However, if entries were imported with definitions instead of glosses (e.g., from WeSay) but aren't protected, then users cannot edit and save them.

Action items:

  • Allow saving entries if gloss OR definition is nonempty
  • Add corresponding string to "reviewEntries.error.gloss" ("Glosses cannot be left blank") for projects with definitions (e.g., "Glosses and definitions cannot both be left blank")
@imnasnainaec imnasnainaec added bug Something isn't working frontend goal: ReviewEntries Size: S Small sized issue labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend goal: ReviewEntries Size: S Small sized issue
Projects
None yet
Development

No branches or pull requests

1 participant