Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MergeDups] Enable bypassing protection of protected words and senses #3445

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[MergeDups] Enable bypassing protection of protected words and senses #3445

wants to merge 8 commits into from

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 13, 2024 •
edited by jasonleenaylor
Loading

Resolves #3444

This change is Reviewable

@imnasnainaec imnasnainaec added enhancement New feature or request goal: MergeDup labels Nov 13, 2024
@imnasnainaec imnasnainaec self-assigned this Nov 13, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.13386% with 90 lines in your changes missing coverage. Please review.

Project coverage is 74.44%. Comparing base (5251099) to head (c5e9cc6).

Files with missing lines Patch % Lines
...ergeDuplicates/MergeDupsStep/protectReasonUtils.ts 2.27% 43 Missing ⚠️
...geDuplicates/MergeDupsStep/MergeDragDrop/index.tsx 23.25% 32 Missing and 1 partial ⚠️
...MergeDuplicates/MergeDupsStep/SaveDeferButtons.tsx 0.00% 6 Missing ⚠️
...nents/ProjectSettings/ProjectProtectedOverride.tsx 57.14% 3 Missing ⚠️
...s/MergeDupsStep/MergeDragDrop/SidebarDragSense.tsx 0.00% 2 Missing ⚠️
src/components/UserSettings/UserSettings.tsx 0.00% 1 Missing ⚠️
...uplicates/MergeDupsStep/MergeDragDrop/DropWord.tsx 0.00% 1 Missing ⚠️
...MergeDuplicates/MergeDupsStep/SenseCardContent.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3445      +/-   ##
==========================================
- Coverage   74.65%   74.44%   -0.22%     
==========================================
  Files         285      287       +2     
  Lines       10999    11065      +66     
  Branches     1338     1347       +9     
==========================================
+ Hits         8211     8237      +26     
- Misses       2404     2444      +40     
  Partials      384      384
Flag Coverage Δ
backend 83.63% <100.00%> (+0.01%) ⬆️
frontend 66.33% <23.07%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@imnasnainaec imnasnainaec

Labels
enhancement New feature or request frontend goal: MergeDup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MergeDups] Allow override of protected words/senses
1 participant
@imnasnainaec