-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed BackgroundWorkers to async await #728
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AndrewChristensenFCBH and @tombogle)
GlyssenEngine/Project.cs, line 1466 at r1 (raw file):
ParseAndIncludeBooks
Should this be named ParseAndIncludeBooksAsync?
GlyssenEngine/Project.cs, line 1528 at r1 (raw file):
ProjectState = ProjectState.UsxComplete | (ProjectState & ProjectState.WritingSystemRecoveryInProcess);
Should this line get moved into GuessAtQuoteSystem?
It doesn't matter now because this is the only caller. But someone looking just at the (albeit private) API might think GuessAtQuoteSystemAsync and GuessAtQuoteSystem are the same except for synchronicity.
GlyssenEngine/Project.cs, line 1549 at r1 (raw file):
m_projectMetadata.ParserVersion = kParserVersion; ProjectState = ProjectState.Parsing;
Same comment as for GuessAtQuoteSystemAsync above.
GlyssenEngine/Project.cs, line 1466 at r1 (raw file): Previously, andrew-polk wrote…
Could be. I only added the Async suffix for the methods where I needed a synchronous and asynchronous version. Not even sure this branch is a "keeper".... |
GlyssenEngine/Project.cs, line 1528 at r1 (raw file): Previously, andrew-polk wrote…
Yes it should. There is another caller. |
Added error-handler to Paratext-based constructor so Vessel can specify its own error handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk and @AndrewChristensenFCBH)
This change is