VerificationResult now has a proper mediaType field. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phill MV <[email protected]>
I actually find the switch statement here MORE confusing than the if else, so I have taken the liberty to disable gocritic for this particular if. Signed-off-by: Phill MV <[email protected]>
phillmv
changed the title
Signed-off-by: Phill MV <[email protected]>
kommendorkapten
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #13
As described in the issue, this PR solves the problem of
VerificationResults.Versionbeing insufficiently descriptive and incongruous with the other json document types that are handled in the broader Sigstore ecosystem.This PR:
Version inttoMediaType stringapplication/vnd.dev.sigstore.verificationresult+json;version=0.1WithoutArtifactUnsafe()in thesigstore-gobinary, which I used to test this feature.Release Note
Documentation
We haven't created a release for this yet, so I don't think any additional docs changes are necessary beyond what will be generated when we do create a release for this library.