Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fulcio HTTP ingress TLS option has wrong indentation in the default values #828

Open
vipulagarwal opened this issue Sep 4, 2024 · 0 comments
Open

Fulcio HTTP ingress TLS option has wrong indentation in the default values #828

vipulagarwal opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vipulagarwal
Copy link
Contributor

Description
Fulcio ingress TLS option has the wrong indentation in the values.

As per http ingress template, the TLS option is enabled via .Values.server.ingress.tls. However, the default values makes use of .Values.server.ingress.http.tls

Right now this is broken when making use of default values. I would recommend that we fix the template since .Values.server.ingress.http.tls makes more sense and goes along with .Values.server.ingress.grpc.tls pattern.

Version
fulcio-2.5.3
@vipulagarwal vipulagarwal added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vipulagarwal