Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to go1.23 #1796

Merged
merged 1 commit into from
Sep 10, 2024
Merged

upgrade to go1.23 #1796

merged 1 commit into from
Sep 10, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 4, 2024

  • upgrade to go1.23

@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.35%. Comparing base (cf238ac) to head (4756849).
Report is 196 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ca/googleca/v1/googleca.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1796      +/-   ##
==========================================
- Coverage   57.93%   50.35%   -7.58%     
==========================================
  Files          50       70      +20     
  Lines        3119     4180    +1061     
==========================================
+ Hits         1807     2105     +298     
- Misses       1154     1843     +689     
- Partials      158      232      +74

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

haydentherapper
haydentherapper reviewed Sep 5, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@cpanato cpanato marked this pull request as draft September 5, 2024 20:24
@cpanato cpanato marked this pull request as ready for review September 10, 2024 16:31
@cpanato
Copy link
Member Author

cpanato commented Sep 10, 2024

@haydentherapper would you mind to take another look?

haydentherapper
haydentherapper reviewed Sep 10, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@cpanato
upgrade to go1.23.1
4756849 
Signed-off-by: cpanato <[email protected]>
haydentherapper
haydentherapper approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cpanato cpanato merged commit ba53f27 into sigstore:main Sep 10, 2024
13 checks passed
@cpanato cpanato deleted the upgrade-go-123 branch September 10, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydentherapper haydentherapper haydentherapper approved these changes

@bobcallaway bobcallaway Awaiting requested review from bobcallaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpanato @haydentherapper