-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit Compliance GDI specification v1.6.0: Configuration #978
Comments
✅ Signals can be configured via env vars (https://github.com/signalfx/splunk-otel-js/blob/main/docs/advanced-config.md)
✅ We have programmatic options which take precedence over env vars.
✅ We have programmatic options.
✅ https://github.com/signalfx/splunk-otel-js/blob/main/docs/advanced-config.md (imho I don't think anyone really cares whether we deem these experimental or not)
❌ We have a few env vars that are JS specific and would pollute the GDI spec (e.g.
✅ Our extra env vars are prefixed with
✅ Our extra env vars are prefixed with
✅
✅ We are dropping
✅ JS distro provides customization either via programmatic config or via env vars.
✅
✅ https://github.com/signalfx/splunk-otel-js/blob/main/src/start.ts#L107
✅ https://github.com/signalfx/splunk-otel-js/blob/main/src/tracing/options.ts#L282
✅ https://github.com/signalfx/splunk-otel-js/blob/main/src/tracing/options.ts#L53
✅ https://github.com/signalfx/splunk-otel-js/blob/main/src/tracing/options.ts#L215
✅ not applicable |
What do you think of following a rule similar to https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/sdk-environment-variables.md#language-specific-environment-variables:
I think if we have such pattern then it would be easy to distinguish repo-specific features for more general features. We could also simplify the process defined in https://github.com/signalfx/gdi-specification/blob/main/specification/configuration.md to not require any actions in GDI spec for @seemk, thoughts? |
Hmm, I don't really want to change the existing ones, plus as an end user when you're configuring a JS service, I don't think the JS part adds much |
OK. I also see that Java also does more or less the same: https://github.com/signalfx/splunk-otel-java/blob/main/docs/advanced-config.md. I think we should loosen the requirement below:
EDIT: I created signalfx/gdi-specification#326 |
I decided to reopen. There is a lot of not compliant env vars documented here : https://github.com/signalfx/splunk-otel-js/blob/main/docs/advanced-config.md. There are also more (not documented) here: https://github.com/signalfx/splunk-otel-js/blob/main/src/utils.ts There is also an issue signalfx/gdi-specification#326 for handling repo-specific env vars. We should look if we need env vars like The most worrying is the |
|
|
Copy-paste error. I meant |
In Go distro we are not setting up the Trace SDK when AFAIK, one of the reasons behind v3 of |
There is an agreement to keep the additional env vars: signalfx/gdi-specification#326 (comment). Closing 🎉 |
Review compliance against https://github.com/signalfx/gdi-specification/blob/v1.6.0/specification/configuration.md
The text was updated successfully, but these errors were encountered: