Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated comment or helm chart #889

Closed
jrohitdev opened this issue Aug 16, 2023 · 3 comments
Closed

Outdated comment or helm chart #889

jrohitdev opened this issue Aug 16, 2023 · 3 comments
Labels

Comments

@jrohitdev
Copy link

Describe the issue you're reporting

As part of upgrading helm chart it was observed that disable_compression is still true even in the latest version (i.e 0.82.0)

It is unclear if this was supposed to be enabled or if the comment is out-of-date.

https://github.com/signalfx/splunk-otel-collector-chart/blob/splunk-otel-collector-0.82.0/helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl#L116

@jrohitdev jrohitdev changed the title Outdated comment or chart Outdated comment or helm chart Aug 16, 2023
@atoulme
Copy link
Contributor

atoulme commented Oct 10, 2023

We're still going through this, we have a PR open with some discussion. I will follow up on the PR.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. If this issue is still relevant, please leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 11, 2023
@atoulme
Copy link
Contributor

atoulme commented May 29, 2024

Please watch the PR for updates.

@atoulme atoulme closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants