Downgrade androidx to allow lower compileSDK #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
srv-gh-o11y-gdi-cla
added a commit
to splunk/cla-agreement
that referenced
this pull request
Dec 6, 2024
SenNeonoveNoci
requested review from
SenNeonoveNoci
and removed request for
SenNeonoveNoci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note - We do not need to downgrade compileSDK version but I've downgraded it so next when renovate bumps the version of any of our androidx dependencies, build fails and we can add that dependency to renovate rule for ignoring. This is needed as Google has not mentioned exactly what androidx dependencies are requiring compileSDK = 35. The documentation vaguely mentions "Various AndroidX libraries will start requiring compilesdk 35 after August 7th release. If you see AGP warnings when you upgrade compilesdk, you could suppress them."