Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group video call for 1 person #13856

Open
3 tasks done
Sagar0-0 opened this issue Dec 27, 2024 · 1 comment · May be fixed by #13882
Open
3 tasks done

Group video call for 1 person #13856

Sagar0-0 opened this issue Dec 27, 2024 · 1 comment · May be fixed by #13882

Comments

@Sagar0-0
Copy link
Contributor

Sagar0-0 commented Dec 27, 2024

Guidelines

  • I have searched searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

  1. Create a group for 1 person, that is yourself.
  2. Video call in that group.
  3. Only you are there in VC and the call is still going.
  4. This doesn't make sense and should be prevented as this wastes resources.

Possible solutions:

  1. Remove the Video call button.
  2. Show a dialog/Toast when Clicking on the Video call button saying that VC with 1 person isn't possible.

I am ready with 1st solution PR, assign this issue to me to proceed.

Screenshots

document_6300953998052561889.mp4

Device

Realme GT NEO 3T

Android version

14

Signal version

7.28.4

Link to debug log

NA

@Sagar0-0
Copy link
Contributor Author

This issue is fixed, but has a co-related issue. i.e. the Video call can be also started from ConversationSettings Screen. I have also found the responsible code for this and fixed it too.

document_6307481506528892860.mp4

However, I strongly believe this should be handled in a separate issue/PR as these changes are in a Separate File or Workflow. This will lead to better maintainability of the code and we can revert the PR if anything doesn't work as expected. Let me know if I should Open a dedicated Issue or Just a PR for this.

Note: The same situation applies to the Call History too. If all members in a group has left, then we should not allow making a call in the group. A separate PR needs to handle it(I am ready.)

Sagar0-0 added a commit to Sagar0-0/Signal-Android that referenced this issue Jan 6, 2025
@Sagar0-0 Sagar0-0 linked a pull request Jan 6, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant