Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast should be displayed above modal #798

Open
viktorhajer opened this issue Oct 3, 2023 · 10 comments
Open

Toast should be displayed above modal #798

viktorhajer opened this issue Oct 3, 2023 · 10 comments
Assignees
Labels
Workflow: Issue created JIRA issue is created and will be analyzed

Comments

@viktorhajer
Copy link

viktorhajer commented Oct 3, 2023

What happened?

Currently the toast is behind the modal window -> so it is not possible to display toast from dialog.

What type of frontend frameware are you seeing the problem on?

Angular

Which version of iX do you use?

v2.0.3

Code to produce this issue.

export class TestComponent {

  constructor(private readonly modalService: ModalService,
              private readonly toastService: ToastService,) {
    this.toastService.setPosition('top-right');
  }

  open(){
    this.toastService.show({title: 'title', message: 'msg'});
    this.modalService.open({content: DialogComponent, size: '720'});
  }
}
@viktorhajer viktorhajer added the triage We discuss this topic in our internal weekly label Oct 3, 2023
@viktorhajer
Copy link
Author

This is still an issue. I updated the version in the description.

@viktorhajer
Copy link
Author

This is still an issue in 2.0.4. Any update?

@silviowolf silviowolf added Workflow: Issue created JIRA issue is created and will be analyzed and removed triage We discuss this topic in our internal weekly labels Nov 13, 2023
@silviowolf
Copy link
Collaborator

No update 2.0.4, is in backlog but not planned yet.

@viktorhajer
Copy link
Author

Okay, thank you.

@viktorhajer
Copy link
Author

Hi @silviowolf, as I see it is planned now. Can we expect it in the next release (2.1.0)?

@supreethaPavank
Copy link

+1 . I am also facing this issue

@viktorhajer
Copy link
Author

Any update on this issue?

@matthiashader
Copy link
Collaborator

[IX-609]

@raphaelgodart
Copy link

raphaelgodart commented Nov 29, 2024

What's the status on resolving this problem? This bug has been open for quite a while and a fix is become rather urgent. Our team has an upcoming software release. Currently, notifications to the user (including errors) are invisible for the user when a toast is triggered from a modal. Thank you.

@flxlst09
Copy link
Collaborator

Hello @raphaelgodart We understand the importance of this functionality and apologize for the delay in our response. To provide some transparency regarding the challenges we are facing with this issue, here are some of the key considerations we have been working through:

  • Before displaying a toast message, we would need to check if a modal is open. If a modal is open, ensure the toast message is displayed above the modal layer.
  • If a toast message is already open and a modal is triggered, we would need to dynamically adjust the toast’s layer to ensure it remains visible as we want to avoid having toast messages open on multiple layers.
  • We should also define clear rules for user interactions with toast messages while a modal is open. For example, if an action in a toast message requires closing the modal.
  • Given these complexities and the urgency of your project, we have re-prioritized this issue into our Q1 2025 planning. We are committed to finding a robust solution and will keep you updated on our progress.

As a temporary workaround, you could consider not showing the backdrop when opening modal dialogs. This would not entirely solve the problem, but toast messages would be visible.

Thank you for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workflow: Issue created JIRA issue is created and will be analyzed
Projects
None yet
Development

No branches or pull requests

6 participants