Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: angular standalone #1649

Open
wants to merge 54 commits into
base: release-3.0.0
Choose a base branch
from
Open

Conversation

jul-lam
Copy link
Collaborator

@jul-lam jul-lam commented Jan 16, 2025

💡 What is the current behavior?

GitHub Issue Number: IX-2292

  • angular standalone components are not working

🆕 What is the new behavior?

  • angular standalone components are now working

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: f33bbca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jul-lam jul-lam self-assigned this Jan 16, 2025
@jul-lam jul-lam changed the title Feat/angular standalone feat: angular standalone Jan 16, 2025
.changeset/pretty-hairs-agree.md Outdated Show resolved Hide resolved
packages/angular-standalone-test-app/angular.json Outdated Show resolved Hide resolved
packages/angular/src/modules/module.ts Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 17, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
28 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.2% Duplication on New Code

See analysis details on SonarQube Cloud

@jul-lam jul-lam requested a review from danielleroux January 17, 2025 10:36
@danielleroux
Copy link
Collaborator

@jul-lam lgtm before the final review can you please have a look into the sonarcloud issues there are 3 remaining the others 28 issues are accepted because the are generated by stencil output target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants