Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/slider): update tooltip on steps below 1 #1468

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Sep 11, 2024

💡 What is the current behavior?

  • Its possible to configure steps > 1
  • Tooltip does not reflect float numbers -> updates only on full numbers

GitHub Issue Number: #1101, [IX-942]

🆕 What is the new behavior?

  • tooltip also updates on numbers > 1

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 1ea4ec7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@siemens/ix Patch
@siemens/ix-angular Patch
@siemens/ix-react Patch
@siemens/ix-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader marked this pull request as draft September 11, 2024 11:34
Copy link
Contributor

Report of strictNullChecks (strictPropertyInitialization) check

Typescript check

Total errors are the same in both branches

ESLint check

Total ESLint warnings are the same in both branches

@matthiashader matthiashader changed the title fix(core/slider): show tooltip on float steps fix(core/slider): update tooltip on steps below 1 Sep 11, 2024
@matthiashader matthiashader marked this pull request as ready for review September 16, 2024 04:29
@nuke-ellington nuke-ellington merged commit d5affb0 into main Sep 16, 2024
16 checks passed
@nuke-ellington nuke-ellington deleted the fix/942-slider branch September 16, 2024 13:50
This was referenced Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants