fix: dev sync comments

siemens · Nov 28, 2024 · 083fcd0 · 083fcd0
1 parent 2c0e1f0
commit 083fcd0
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 18 deletions.
diff --git a/.changeset/good-mayflies-accept.md b/.changeset/good-mayflies-accept.md
@@ -1,5 +1,4 @@
 ---
-'storybook-docs': patch
 '@siemens/ix-react': patch
 '@siemens/ix': patch
 '@siemens/ix-vue': patch

diff --git a/packages/core/src/components/select/select.tsx b/packages/core/src/components/select/select.tsx
@@ -505,7 +505,7 @@ export class Select implements IxInputFieldComponent<string | string[]> {
     this.cleanupResources();
   }
 
-  private itemExists(item: string) {
+  private itemExists(item: string | undefined) {
     return this.items.find((i) => i.label === item);
   }
 
@@ -551,15 +551,17 @@ export class Select implements IxInputFieldComponent<string | string[]> {
       return;
     }
 
+    const trimmedInput = this.inputFilterText.trim();
+    const itemLabel = (el as HTMLIxSelectItemElement)?.label;
+
     if (
-      !this.itemExists(this.inputFilterText.trim()) &&
-      !this.itemExists((el as HTMLIxSelectItemElement)?.label ?? '')
+      this.editable &&
+      !this.itemExists(trimmedInput) &&
+      !this.itemExists(itemLabel)
     ) {
-      if (this.editable) {
-        const defaultPrevented = this.emitAddItem(this.inputFilterText.trim());
-        if (defaultPrevented) {
-          return;
-        }
+      const defaultPrevented = this.emitAddItem(trimmedInput);
+      if (defaultPrevented) {
+        return;
       }
     }
 

diff --git a/packages/storybook-docs/src/stories/select.stories.ts b/packages/storybook-docs/src/stories/select.stories.ts
@@ -21,7 +21,7 @@ const meta = {
   parameters: {
     design: {
       type: 'figma',
-      url: 'https://www.figma.com/design/r2nqdNNXXZtPmWuVjIlM1Q/iX-Components---Brand-Dark?node-id=594-9899&m=dev',
+      url: 'https://www.figma.com/design/r2nqdNNXXZtPmWuVjIlM1Q/iX-Components---Brand-Dark?node-id=42365-175539&m=dev',
     },
   },
 } satisfies Meta<Element>;
@@ -34,14 +34,18 @@ export const Default: Story = {
 };
 
 export const editableSelect: Story = {
-  render: ({ value, editable, allowClear, disabled, }) => {
-    return html`
-      <ix-select value=${value} ?editable=${editable} ?allow-clear=${allowClear} disabled=${disabled}>
-        <ix-select-item label="Item 1" value="1"></ix-select-item>
-        <ix-select-item label="Item 2" value="2"></ix-select-item>
-        <ix-select-item label="Item 3" value="3"></ix-select-item>
-        <ix-select-item label="Item 4" value="4"></ix-select-item>
-      </ix-select>`;
+  render: ({ value, editable, allowClear, disabled }) => {
+    return html` <ix-select
+      value=${value}
+      ?editable=${editable}
+      ?allow-clear=${allowClear}
+      disabled=${disabled}
+    >
+      <ix-select-item label="Item 1" value="1"></ix-select-item>
+      <ix-select-item label="Item 2" value="2"></ix-select-item>
+      <ix-select-item label="Item 3" value="3"></ix-select-item>
+      <ix-select-item label="Item 4" value="4"></ix-select-item>
+    </ix-select>`;
   },
   args: {
     value: 'Administrator',