Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag preview doesn't work in README #141

Open
bogdan-the-great opened this issue Mar 1, 2023 · 15 comments
Open

Tag preview doesn't work in README #141

bogdan-the-great opened this issue Mar 1, 2023 · 15 comments

Comments

@bogdan-the-great
Copy link

It looks like this: https://ibb.co/Cz2jd5c and cannot be played. Tested on Arch and Windows machines.

@siduck
Copy link
Owner

siduck commented Mar 1, 2023

hi @piotr-marendowski , check config.def.h. It has an option to enable tag preview. Enable it and recompile

@siduck siduck closed this as completed Mar 1, 2023
@bogdan-the-great
Copy link
Author

hi @piotr-marendowski , check config.def.h. It has an option to enable tag preview. Enable it and recompile

I mean in this repository in README Tag preview video isn't playing, because it's corrupted.

@siduck siduck reopened this Mar 2, 2023
@siduck
Copy link
Owner

siduck commented Mar 2, 2023

Oh oops I misread, will fix it soon!

@siduck
Copy link
Owner

siduck commented Mar 6, 2023

@siduck siduck closed this as completed Mar 6, 2023
@MinePro120
Copy link
Contributor

Do you happen to use Chromium @siduck? In firefox it's still not playing. Looking at the firefox console, there seems to be something wrong with the codec. See this bug. I'd go with obs.

@siduck
Copy link
Owner

siduck commented Mar 17, 2023

Do you happen to use Chromium @siduck? In firefox it's still not playing. Looking at the firefox console, there seems to be something wrong with the codec. See this bug. I'd go with obs.

yes

@siduck
Copy link
Owner

siduck commented Mar 17, 2023

Do you happen to use Chromium @siduck? In firefox it's still not playing. Looking at the firefox console, there seems to be something wrong with the codec. See this bug. I'd go with obs.

ffmpeg feels minimal and performant so I use that

@MinePro120
Copy link
Contributor

You can probably pass it the option -pix_fmt yuv420p cause ffmpeg's defaults aren't compatible with firefox according to the previous bug report it seems.

@siduck
Copy link
Owner

siduck commented Mar 17, 2023

You can probably pass it the option -pix_fmt yuv420p cause ffmpeg's defaults aren't compatible with firefox according to the previous bug report it seems.

yuv420p doesnt give me crystal clear colors, but yuv444 does! there was another solution to use librgb codec

my old command

ffmpeg -framerate 60 -f x11grab -i $DISPLAY -c:v libx264rgb -crf 0 -preset ultrafast -color_range 2 vid.mp4

but i use nvidia now and that above command lags so im using h2venc

ffmpeg -f x11grab -framerate 75 -i $DISPLAY -c:v h264_nvenc -probesize 42M -b:v 30M -pix_fmt yuv444p -r 75 v.mp4

@siduck
Copy link
Owner

siduck commented Mar 17, 2023

idk if h264_nvenc has a rgb version :/

@MinePro120
Copy link
Contributor

Whatever works best for you, but it's important that it works on firefox as well 😅.

@siduck
Copy link
Owner

siduck commented Mar 17, 2023

@MinePro120 https://www.youtube.com/@siduck_og I think these play on firefox, i'll put the video on yt and yt will fix it for firefox 🤔

@MinePro120
Copy link
Contributor

That might not be a good idea since github's markdown doesn't support embedding YT videos.

@MinePro120
Copy link
Contributor

I think this should be reopened. Browser compatibility is important, especially firefox.

@siduck siduck reopened this Sep 4, 2023
@MinePro120
Copy link
Contributor

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants