Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default repo settings similar to other siderolabs repos #14

Closed
frezbo opened this issue Mar 28, 2024 · 8 comments · Fixed by #17
Closed

Enable default repo settings similar to other siderolabs repos #14

frezbo opened this issue Mar 28, 2024 · 8 comments · Fixed by #17

Comments

@frezbo
Copy link
Member

frezbo commented Mar 28, 2024

Coming in from this: #12 (comment)

i would be beneficial to have this repo have default settings similar to other repos under the organization.

Have a default main branch and have the standard repo branch protection settings enabled.

@robinelfrink / @lennardk I can help get this started

@robinelfrink
Copy link
Collaborator

Yes, I'm all in for uniform repository settings :)

I'll make sure we rework the repo-content with kres as soon as we have released 0.5.0.

@frezbo
Copy link
Member Author

frezbo commented Mar 28, 2024

Yes, I'm all in for uniform repository settings :)

I'll make sure we rework the repo-content with kres as soon as we have released 0.5.0.

Yup great 👍

@frezbo
Copy link
Member Author

frezbo commented Mar 28, 2024

I'll put up a draft PR to help things to be easier, and once 0.5.0 is released, will enforce the repository settings.

@frezbo
Copy link
Member Author

frezbo commented Mar 28, 2024

Oh, i didn't realize 0.5.0 is already cut that was fast, I'll start by renaming the branch to main, WDYT?

@robinelfrink
Copy link
Collaborator

I just now created the release :) Yes, if you will, please go.

@frezbo
Copy link
Member Author

frezbo commented Mar 28, 2024

I just now created the release :) Yes, if you will, please go.

Done, might need this local updates:

git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

@robinelfrink
Copy link
Collaborator

Thanks. I've updated the workflow definition to reflect the branch rename, even though I suspect kres will make that obsolete anyway.

@frezbo
Copy link
Member Author

frezbo commented Mar 28, 2024

Yeh, kres generates even gh workflow files

frezbo added a commit to frezbo/talos-vmtoolsd that referenced this issue Mar 28, 2024
Just adds in the golangcilint file from kres so this should be a no-op
PR.

Part of: siderolabs#14

Signed-off-by: Noel Georgi <[email protected]>
robinelfrink pushed a commit that referenced this issue Mar 28, 2024
Just adds in the golangcilint file from kres so this should be a no-op
PR.

Part of: #14

Signed-off-by: Noel Georgi <[email protected]>
frezbo added a commit to frezbo/talos-vmtoolsd that referenced this issue Mar 28, 2024
Enable kres and update repo branch settings.

Fixes: siderolabs#14

Signed-off-by: Noel Georgi <[email protected]>
frezbo added a commit to frezbo/talos-vmtoolsd that referenced this issue Mar 28, 2024
Enable kres and update repo branch settings.

Fixes: siderolabs#14

Signed-off-by: Noel Georgi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants