Add carbon metrics to get dashboard support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into develop � Conflicts: � component/src/main/java/io/siddhi/extension/io/file/FileSource.java � component/src/main/java/io/siddhi/extension/io/file/util/FileSourceConfiguration.java � docs/api/latest.md � docs/index.md � pom.xml
ramindu90
requested changes
Jun 3, 2020
| MetricsDataHolder.getInstance().getMetricManagementService().isEnabled()) { | ||
| try { | ||
| if (MetricsDataHolder.getInstance().getMetricManagementService().isReporterRunning( | ||
| "prometheus")) { |
There was a problem hiding this comment.
Shall we make this a constant? Maybe it should be a constant in the carbon metrics package.
There was a problem hiding this comment.
This was fixed in 85ee5fb, There's no constant available in the carbon metrics, Hence introduce as a new constant.
| fileCopyMetrics = new FileCopyMetrics(siddhiAppName); | ||
| } | ||
| } catch (IllegalArgumentException e) { | ||
| log.debug("Prometheus reporter is not running. Hence file metrics will not be initialise in " |
There was a problem hiding this comment.
Maybe this should be rephrased as "will not be initialized"
There was a problem hiding this comment.
This was fixed in 85ee5fb
ramindu90
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
fix #87
Security checks
Related PRs
wso2/carbon-analytics#1849