Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve any issues from coverity static analysis #57

Open
trgill opened this issue Feb 5, 2021 · 4 comments
Open

resolve any issues from coverity static analysis #57

trgill opened this issue Feb 5, 2021 · 4 comments

Comments

@trgill
Copy link
Contributor

trgill commented Feb 5, 2021

https://docs.google.com/document/d/1BbO6Xt7VVJtdDeHNZT3k9GP282PtynTMFL0Du263Kw4/edit?usp=sharing

@trgill
Copy link
Contributor Author

trgill commented Feb 5, 2021

@prajnoha Coverity doesn't like assignments in "if" statements. For example:

if (!(alloc_step = buf->stat.init.alloc_step))

Of cases where we use (like above) or:
!integer_variable

I'm thinking I'll just mark these as style issues rather than change the code. That ok with you?

@prajnoha
Copy link
Member

prajnoha commented Feb 5, 2021

Sure, let's keep those as they are for now - they're throughout the whole code so that would be lots of changes.

@prajnoha
Copy link
Member

prajnoha commented Feb 8, 2021

PR #58

@trgill
Copy link
Contributor Author

trgill commented Feb 11, 2021

PR #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants