[v3] avoid focus-visible style being cut off by overflow hidden #3149
Conversation
🦋 Changeset detectedLatest commit: b918b8e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@87xie is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -191,7 +191,7 @@ const config: DocsThemeConfig = { | |||
| }, | |||
| toc: { | |||
| extraContent: ( | |||
| <img alt="placeholder cat" src="https://placekitten.com/g/300/200" /> | |||
| <img alt="placeholder cat" src="https://placecats.com/300/200" /> | |||
There was a problem hiding this comment.
In example/swr-site, placekitten seems to be down, so I replaced it with placecats.
| <OnFocusItemContext.Provider | ||
| value={item => { | ||
| setFocused(item) | ||
| }} | ||
| > | ||
| <OnFocusItemContext.Provider value={setFocused}> |
There was a problem hiding this comment.
It seems that the extra inline function is not needed.
87xie
changed the title
| @@ -183,7 +183,7 @@ function FolderImpl({ item, anchors }: FolderProps): ReactElement { | |||
| )} | |||
| /> | |||
| </ComponentToUse> | |||
| <Collapse className="ltr:_pr-0 rtl:_pl-0 _pt-1" isOpen={open}> | |||
| <Collapse className="_p-1" isOpen={open}> | |||
There was a problem hiding this comment.
To resolve a situation like this
|
closed by #3160, thanks for the initial attempt 🙌 |
87xie
deleted the
avoid-focus-visible-style-being-cut-off-by-overflow-hidden
branch
fixes #1432
Description
I noticed some adjustments to the focus-visible style in Auth.js related to Nextra, such as:
I think these adjustments could be applied more comprehensively within Nextra. For instance, Auth.js only targets the focus-visible style of the first-level sidebar items and the focus-visible style is not working well in the TOC either.
Screenshots
Sidebar
Tabs
TOC
Direction: rtl