Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] fix html lang attribute #5639

Open
3 of 4 tasks
shopwareBot opened this issue Nov 21, 2024 · 2 comments
Open
3 of 4 tasks

[GitHub] fix html lang attribute #5639

shopwareBot opened this issue Nov 21, 2024 · 2 comments

Comments

@shopwareBot
Copy link

1. Why is this change necessary?

In case, you use inherited language, the html lang attribute is empty.

2. What does this change do, exactly?

  • Changed HeaderPageletLoader::getLanguages to load associated locale
  • Changed base.html.twig to use activeLanguage.locale instead of activeLanguage.translationCode. In case of inherited languages, the translationCode is null, whereas locale stores the inherited locale.

3. Describe each step to reproduce the issue or behaviour.

  1. Create a language, that inherits another language.
  2. Assign the language to your storefront.
  3. Open the storefront in that language.
  4. Check the lang attribute in the html tag.

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change <- I couldn't think of a useful test for this
  • I have created a changelog file with all necessary information about my changes
  • I have read the contribution requirements and fulfil them.

copilot:summary

copilot:walkthrough


Imported from Github. Please see: #3070

@shopware-issue-bot
Copy link

We found the following existing issues which may help or are related to your topic:

@github-actions github-actions bot added the Bug label Nov 21, 2024
@shopwareBot
Copy link
Author

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-26889

[created from NEXT-26889, comment 514971]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant