You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In case, you use inherited language, the html lang attribute is empty.
2. What does this change do, exactly?
Changed HeaderPageletLoader::getLanguages to load associated locale
Changed base.html.twig to use activeLanguage.locale instead of activeLanguage.translationCode. In case of inherited languages, the translationCode is null, whereas locale stores the inherited locale.
3. Describe each step to reproduce the issue or behaviour.
Create a language, that inherits another language.
Assign the language to your storefront.
Open the storefront in that language.
Check the lang attribute in the html tag.
4. Please link to the relevant issues (if any).
5. Checklist
I have rebased my changes to remove merge conflicts
I have written tests and verified that they fail without my change <- I couldn't think of a useful test for this
I have created a changelog file with all necessary information about my changes
I have read the contribution requirements and fulfil them.
1. Why is this change necessary?
In case, you use inherited language, the html lang attribute is empty.
2. What does this change do, exactly?
HeaderPageletLoader::getLanguages
to load associated localebase.html.twig
to useactiveLanguage.locale
instead ofactiveLanguage.translationCode
. In case of inherited languages, thetranslationCode
is null, whereaslocale
stores the inherited locale.3. Describe each step to reproduce the issue or behaviour.
lang
attribute in thehtml
tag.4. Please link to the relevant issues (if any).
5. Checklist
copilot:summary
copilot:walkthrough
Imported from Github. Please see: #3070
The text was updated successfully, but these errors were encountered: