-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vue-demo-store): a11y improvements #402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
BrocksiNet
reviewed
Sep 28, 2023
BrocksiNet
reviewed
Sep 28, 2023
BrocksiNet
reviewed
Sep 28, 2023
BrocksiNet
reviewed
Sep 28, 2023
BrocksiNet
approved these changes
Sep 28, 2023
patzick
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #401
solves all critical and serious issues. Some contrast issues cannot be tracked and found to fix (hidden DOM elements 🤔 probably). there are still some small issues in "alert" level mainly for redundant links for product (described in notes section).
In order to fix many of contrast errors, I needed to tweak up the level of text colors, like for:
text-blue-500 -> text-blue-600, and so on. would be good to see if it goes aligned to our visual identity (if there is any).
Notes
Used tools
Type of change
Screenshots (if applicable)
Additional context