Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue-demo-store): a11y improvements #402

Merged
merged 10 commits into from
Oct 3, 2023

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Sep 22, 2023

Description

closes: #401

solves all critical and serious issues. Some contrast issues cannot be tracked and found to fix (hidden DOM elements 🤔 probably). there are still some small issues in "alert" level mainly for redundant links for product (described in notes section).

In order to fix many of contrast errors, I needed to tweak up the level of text colors, like for:
text-blue-500 -> text-blue-600, and so on. would be good to see if it goes aligned to our visual identity (if there is any).

Notes

  • dynamic content coming from API (CMS) cannot be fixed in the project. keep in mind that HTML from Shopping Experiences is not always valid in terms of accessibility rules.
  • there is a problem with redundant links (see link purposes guideliness) with Product card -> one link for product's title, second for product image. we can rethink the structure of Product Card in order to place add to wishlist links in outer area to make possible wrapping in a link the image and title together.

Used tools

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Additional context

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Oct 2, 2023 7:18am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Oct 2, 2023 7:18am

@patzick patzick merged commit 9a89f40 into main Oct 3, 2023
8 checks passed
@patzick patzick deleted the feat/demo-store-a11y-compatibility branch October 3, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Accessibility Improvements
3 participants