Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add nginx variant #109

Merged
merged 6 commits into from
Oct 14, 2024
Merged

feat: add nginx variant #109

merged 6 commits into from
Oct 14, 2024

Conversation

shyim
Copy link
Member

@shyim shyim commented Oct 14, 2024

@dallyger anything what is missing here?

nginx/rootfs/etc/nginx/nginx.conf Outdated Show resolved Hide resolved
@dallyger
Copy link
Contributor

Seems okay, but I don't really know nginx. Thats just what was documented previously, so we used it.

The config differs from the documented configurations at https://developer.shopware.com/docs/resources/references/config-reference/server/nginx.html#nginx and https://developer.shopware.com/docs/guides/installation/requirements.html#webserver (and they themselves differ too). May be worth a look too.

@shyim shyim merged commit ef413dc into main Oct 14, 2024
21 checks passed
@shyim shyim deleted the add-nginx branch October 14, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants