From 6989c182ad31589486f1b8248ad50d560968eaf0 Mon Sep 17 00:00:00 2001 From: Martin Grossmann Date: Thu, 30 May 2024 16:24:31 +0200 Subject: [PATCH] packages now dont run coding standards separately --- .github/workflows/run-checks-tests.yaml | 4 --- composer.json | 6 ++-- ecs.php | 43 ------------------------- 3 files changed, 2 insertions(+), 51 deletions(-) delete mode 100644 ecs.php diff --git a/.github/workflows/run-checks-tests.yaml b/.github/workflows/run-checks-tests.yaml index 0c6b132..00fc288 100644 --- a/.github/workflows/run-checks-tests.yaml +++ b/.github/workflows/run-checks-tests.yaml @@ -20,9 +20,5 @@ jobs: tools: composer - name: Install Composer dependencies run: composer install --optimize-autoloader --no-interaction - - name: Run parallel-lint - run: php vendor/bin/parallel-lint ./src ./tests - - name: Run Easy Coding Standards - run: php vendor/bin/ecs check --verbose ./src ./tests - name: Run PHPUnit run: php vendor/bin/phpunit tests diff --git a/composer.json b/composer.json index 73c8c9c..9bd5bdc 100644 --- a/composer.json +++ b/composer.json @@ -40,13 +40,11 @@ "twig/twig": "^3.5.0" }, "require-dev": { - "phpunit/phpunit": "^9.5.20", - "shopsys/coding-standards": "15.0.x-dev" + "phpunit/phpunit": "^9.5.20" }, "config": { "allow-plugins": { - "symfony/flex": true, - "dealerdirect/phpcodesniffer-composer-installer": true + "symfony/flex": true } } } diff --git a/ecs.php b/ecs.php deleted file mode 100644 index 4dee604..0000000 --- a/ecs.php +++ /dev/null @@ -1,43 +0,0 @@ -rule(ForceLateStaticBindingForProtectedConstantsSniff::class); - - /* - * this package is meant to be extensible using class inheritance, - * so we want to avoid private visibilities in the model namespace - */ - $services = $ecsConfig->services(); -$services->set('forbidden_private_visibility_fixer.brand_feed_luigis_box', ForbiddenPrivateVisibilityFixer::class) - ->call('configure', [ - [ - 'analyzed_namespaces' => [ - 'Shopsys\BrandFeed\LuigisBoxBundle\Model', - ], - ], - ]); - - $ecsConfig->skip([ - ObjectIsCreatedByFactorySniff::class => [ - __DIR__ . '/tests/*', - ], - PhpdocToPropertyTypeFixer::class => [ - __DIR__ . '/src/*', - ], - ]); - - $ecsConfig->import(__DIR__ . '/vendor/shopsys/coding-standards/ecs.php', null, true); -};