Image comparer and Carousel issues #36
aguilar1181
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I have been playing around with the alpha version and encounter a few issues.
1- The image comparer should follow a similar style to the carousel. The carousel has an aspect-ratio set, but the image comparer does not. This causes the images to get distorted Additionally, image comparer should have style display property set to flex just like the carousel. When used on a page without a container, the image comparer does not centers like the carousel due to having
display: inline-block
instead of 'flex'. In my test, I am using 2 images with the exact same size 1200x800 on both components. I am importing the modules individually and loading the CSS globally.2- In the carousel if I don't apply any attributes such as navigation, pagination, loop, etc. the images on the carousel don't display appropriately. if I add attributes navigation, pagination, loop it shows a bit better but still has a small gap BUT only on initial load. And no the "scroll-hint" or "slide-gap" is not set
attributes navigation, pagination, and loop applied
no attributes
3- Not sure if this should be applied at the component level or not. Many developers used CSS frameworks of some sort and most have image max-width set. But if you are not using a framework or have any CSS rules, should the images inside the components have a
max-width: 100%; height: auto;
?no styles applied to image
styles applied to image
I am looking forward to Web Awesome being production ready. I am excited of how it works so far.
Beta Was this translation helpful? Give feedback.
All reactions