From 4e1f78439aa6a0bfb574fe12c0f0c5baf8bd88b6 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Mon, 28 Oct 2024 13:59:41 -0400 Subject: [PATCH 1/2] fix invalid rule --- src/components/tab/tab.styles.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/components/tab/tab.styles.ts b/src/components/tab/tab.styles.ts index 0473b3c6d1..fdf6ec284b 100644 --- a/src/components/tab/tab.styles.ts +++ b/src/components/tab/tab.styles.ts @@ -31,11 +31,8 @@ export default css` outline: transparent; } - :host(:focus-visible):not([disabled]) { - color: var(--sl-color-primary-600); - } - :host(:focus-visible) { + color: var(--sl-color-primary-600); outline: var(--sl-focus-ring); outline-offset: calc(-1 * var(--sl-focus-ring-width) - var(--sl-focus-ring-offset)); } From ccadbafbc12927da26d4a4d1eb62f9e99c40b53d Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Mon, 28 Oct 2024 14:05:10 -0400 Subject: [PATCH 2/2] fixes #2107 --- docs/pages/resources/changelog.md | 1 + src/components/textarea/textarea.component.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md index 520667fe38..b50f906ed2 100644 --- a/docs/pages/resources/changelog.md +++ b/docs/pages/resources/changelog.md @@ -17,6 +17,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti - Added support for Enter to `` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/) [#2234] - Fixed a bug in `` that caused the navigation icons to be reversed - Fixed a bug in `` that prevented label changes in `` from updating the controller [#1971] +- Fixed a bug in `` that caused a console warning in Firefox when typing [#2107] - Improved performance of `` by skipping positioning logic when tooltip isn't shown [#2064] ## 2.18.0 diff --git a/src/components/textarea/textarea.component.ts b/src/components/textarea/textarea.component.ts index 51fbfdfbc7..e76dfbf18c 100644 --- a/src/components/textarea/textarea.component.ts +++ b/src/components/textarea/textarea.component.ts @@ -202,7 +202,7 @@ export default class SlTextarea extends ShoelaceElement implements ShoelaceFormC this.input.style.height = 'auto'; this.input.style.height = `${this.input.scrollHeight}px`; } else { - (this.input.style.height as string | undefined) = undefined; + this.input.style.height = ''; } }