deploy shipwright triggers via operator #129
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jkhelil
force-pushed
the
deploy_triggers
branch
2 times, most recently
from
4beaff9 to
ce5f467
Compare
|
|
||
| r.Manifest, err = manifestival.NewManifest( | ||
| buildManifest, | ||
| dataPath, |
There was a problem hiding this comment.
I think the trigger is the option component, so it would be great if do not deploy trigger by default.
There was a problem hiding this comment.
It is now optional, regarding if we set an env var to install the triggers or not
| serviceAccountName: shipwright-triggers | ||
| containers: | ||
| - name: shipwright-triggers | ||
| image: "quay.io/jkhelil/openshift-builds-triggers:latest" |
There was a problem hiding this comment.
Use official image from shipwright.
There was a problem hiding this comment.
the official image is not publsihed, lets wait for it to be published then, I will update it
There was a problem hiding this comment.
LGTM for deploy triggers via operator.
/cc @SaschaSchwarze0
openshift-ci
bot
added
the
do-not-merge/hold
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes