Overmap Expansion #5

[rye-rice]

About The Pull Request

I said I would PR this by Dec 1st, and I did. Barely.

I need to clean this the fuck up, the branch is really messy with a ton of unused stuff left over, but never say I don't keep my word. I need a few days more to clean this up.

I have tested this and it does function.

Introduction

Happy Holidays Shiptest!

This project initially started as yet another "add more planets, more stuff to do" PR, but as I have seen, even overmap expansion # 4 didn't really accomplish the goal of making people feel more connected to the overmap, or really making the overmap more interesting... The only interesting parts were the planets as was always the case.

So in order to do this, I have done several (Many!) things...

To keep it simple and easy to understand I have split:

For Players:

Overmap sprites have been almost completely redrawn in a nice and easy to click style

As you might have noticed by the numbers, limited lifespan hazards. The issue with the old overmap is that it felt very static and not very "alive". This aims to fix it and add some depth, and also to keep people away from the sun.

You also might notice the asteroid field "planet" is nowhere to be seen. Well, they're actually everywhere! You just need to dock to empty space while on top of an asteroid field.

What's Malachite?

New ores were added, along with new materials. The ore rates on some planets were jacked the fuck up to make different planets worth visiting if you need X material.

Examining planets will allow you to see which ores are on what, alongside the "Materials and You" book that spawns on every ship now!

Greebles

Radio Interference

Wideband radio sound

Nebulas/new hazards

Interactions

Fauna balance

Plasteel --> Carbon Steel

Ore vein for most planets + mission changes

Because we have a dedicated team of spriters here, most if not all planets have gotten a makeover...

For Admins:

For my fellow eventmins, you have 2 more buildmode tools, these actually manipulate the overmap unlike BUILD_ADV before which only messed with the token
Modif Overmap works like BUILD_ADV but only for the overmap, while (//) --> Overmap moves overmap objects, like the move tool

VV options

Multi-Overmap Support

Overmap Palletes

Better Upload Template UI

Static Overmap Objects

New Planets

For Coders:

In order to get some things to work, this splits the overmap off from SSovermap .(/datum/overmap_star_system/. This techinically allows for mutiple overmaps, but the main purpose was to make the code more modular. I found this much easier to work with than having to go look at SSovermap constantly.

Explanation of punch-cards:

Greebles but in depth.

There are now mutiple sprites for overmap ships! By default it's the second one in that screenshot. You can edit it in the ship config json by adding:
to add this in your json add:

    "token_icon_state": "ship_small_generic",

And make sure it has one of these icon states

Technically you could name it anything in this file but ill suplex you if you do.

https://github.com/user-attachments/assets/6f7c6ddf-09c5-4090-b8dc-68ed05cf3ca9
Debugging Docking Ports - New Shuttle Goggles

Interactions but in depth

Transit levels are MUCH bigger, this was due to an attempt to code in ship to ship docking. This is actually possible, however it would require remapping every ship, so I will do that in some follow-up PR. If you want to help me in the meantime, you can offset where your ship spawns in the transit level by adding this to your config JSON:

    "tranist_x_offset": -5,
    "tranist_y_offset": -5,

This won't cause issues if unset, so don't worry about it.

To avoid remapping, all the new materials + materials and you spawn in once on top of the ship's autolathe.
You can disable this by setting this in your ship's config, in case you map these in:

    "spawn_matbundle": 0,

A full changelog is in the CL!

Requires #3512

Credits!

Credits:

• Imaginos16/Spooky: Planet spriters. Fucking huge thanks to you two holy shit this would be so much harder without their help
• • Lava: Imaginos16/Spooky
• • Ice: Spooky
• • Jungle: N/A (uses re-palleted Imaginos sprites)
• • Sand: Imaginos16
• • Rock: N/A
• • Waste: Imaginos16
• • Moon: N/A (uses re-palleted Spooky sprites)
• • Desert: Spooky
• • ???: N/A (uses re-palleted Spooky sprites)
• • Water: N/A
• • Asteroid N/A (uses re-palleted Imaginos sprites)
• Horizon: The extra planets were ported from there at first, and any remaining sprites from the original port are from there
• • The ambient sounds and footsteps are from Horizon
• Solar Flare Alarm and Sound Effect are from Skyrat/Nova Sector/Bubberstation/Whichever Chinese Warring States Period Server is the current main holder of the Skyrat codebase
• Wideband sound and interference sound are from Chatterer
• Water sprite was taken from CM13

Changelog

🆑 ryerice, Imaginos16, spooky, Horizon, Nebula (presumably), MarkSuckerberg
add: Added new things
add: Added more things
del: Removed old things
tweak: tweaked a few things
balance: rebalanced something
fix: fixed a few things
soundadd: added a new sound thingy
sounddel: removed an old sound thingy
imageadd: added some icons and images
imagedel: deleted some icons and images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl:

[FalloutFalcon]

first review. not even kinda done..
this is very unatomic please dont make one of these again.

[FalloutFalcon]

Suggested change

	shell_damage(max(P.force, MAX_BULLET_SHELL_DAMAGE))
	shell_damage(min(P.force, MAX_BULLET_SHELL_DAMAGE))

[FalloutFalcon]

you shouldnt even be running this proc if it has a client.

[FalloutFalcon]

Why?

[FalloutFalcon]

Could be in a better spot (probally mob helpers) or not global

[FalloutFalcon]

Reasoning?

[FalloutFalcon]

Reasoning?

[FalloutFalcon]

I would recommend using an effect where they are still visible while burrowed.

[FalloutFalcon]

Suggested change

	AIStatus = AI_ON
	toggle_ai(AI_ON)

[FalloutFalcon]

Suggested change

	AIStatus = AI_OFF
	toggle_ai(AI_OFF)

[FalloutFalcon]

bad regex..

Suggested change

	name = BIOME_COLD
	name = "Cold"

[Erikafox]

I think legally speaking we need to not use the ftl sfx for storms and stuff.

[Erikafox]

this really needs better feedback for admin usage. It shouldn't be a pain in the ass to create jump points and link them.

[Erikafox]

interacting with one as a ghost should move you to the linked point

[Erikafox]

This should be in the cl or removed.

[Erikafox]

stars should be POIs for ghosts to make transitioning between overmaps smoother

[Erikafox]

the sidings here are big enough to make it impossible to click on some tiles. that's way too big.

[Erikafox]

still having issues with greebles loading after planetload. the screencap was of a greeblespawner just floating but then it loaded.

[Erikafox]

objects of interest should not be spawning in lava.

[Erikafox]

tile overlays: this fucking sucks

[Erikafox]

the forests aren't fun when they're like this

[Erikafox]

every single tile in this area of gen has a tree dare i venture this is the opposite of fun

[Erikafox]

the sidings here are big enough to make it impossible to click on some tiles. that's way too big.

Better example

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.