Pedalpalooza-specific page template #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 1, 2024 16:57
…l scripts only as needed for those specific calendar page types; consolidated some scripts in cal/scripts.html
|
Fixes #798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
caleventslayout template was a bit overloaded with is-it-PP-or-not logic, so this splits that out to its own page template. That also lets us be more exact in which calendar scripts load on which calendar pages. e.g. now the FullCalendar scripts can be omitted from the default list view (/calendar)Also, consolidated most calendar scripts into
layouts/partials/cal/scripts.html, so the usage is now similar tolayouts/partials/cal/head.html. There's still some more untangling we can do to avoid some of these conditional load statements, but this at least organizes it a bit better and in some cases trims down the page transfer size.Note: This doesn't resolve #744 — I added a bit of logic to prevent unneeded partials from loading, but we could still use a dedicated page template for those older ones.