Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Font Awesome usage #792

Open
carrythebanner opened this issue Jul 31, 2024 · 1 comment
Open

Evaluate Font Awesome usage #792

carrythebanner opened this issue Jul 31, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file frontend

Comments

@carrythebanner
Copy link
Collaborator

The front end theme uses Font Awesome, but only in a few places. If our usage is minimal and can be replaced with a few custom icons, we could consider dropping it as a dependency.

If we do want to keep it, note that we're using an old, unmaintained version (v4.7.0; see https://fontawesome.com/versions). I'm not aware of anything particularly problematic about using an old icon library, but worth looking at the newer versions to see what they offer.

@carrythebanner carrythebanner added frontend dependencies Pull requests that update a dependency file labels Jul 31, 2024
@ionous
Copy link
Contributor

ionous commented Aug 2, 2024

i think this is the extent of font-awesome usage:
https://github.com/search?q=repo%3Ashift-org%2Fshift-docs+%22fa+%22&type=code

  • theme.css: not applicable if not used
  • readme: just documentation
  • front.js: for owlCarousel buttons, but it looks like even though the code specifies icons; it explicitly hides them.
  • 404.html layout: but actually the site only uses that in local development, netlify copies a different 404 page over top of it.
  • nav.html partial - the "hamburger" menu when for narrow pages ( ex. on mobile )
  • list.html layout -- but the site doesn't actually those listing pages ( ex https://www.shift2bikes.org/archive/ )

so, tentatively, just the menu icon is used:

image

we could use <span class="glyphicon glyphicon-align-justify" ></span> from bootstrap3 (which is already included) as a close replacement ( maybe adding an additional class to tweak the span's margin, etc. to match what's in theme.css )

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend
Projects
None yet
Development

No branches or pull requests

2 participants