Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect conversion factor for pt to px #42

Open
pfheatwole opened this issue Jun 25, 2020 · 1 comment
Open

Incorrect conversion factor for pt to px #42

pfheatwole opened this issue Jun 25, 2020 · 1 comment

Comments

@pfheatwole
Copy link

imagesize_py/imagesize.py

Line 74 in 5b8557e

return int(length) * 96 / 6

Assuming DPI=96, converting points to pixels should be 96 / 72. SVG files using pt are wrong by a factor of 12.
@pfheatwole pfheatwole mentioned this issue Jun 25, 2020
Closed
@tk0miya
Copy link
Contributor

tk0miya commented Jun 26, 2020

+1. Let's post a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tk0miya @pfheatwole