Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns (-1,-1) instead of exception when used on something unsupported #30

Open
TobiX opened this issue Jan 4, 2020 · 0 comments
Open

Comments

@TobiX
Copy link

TobiX commented Jan 4, 2020

When using imagesize.get() on anything which is not supported (text files, empty files, etc.), the method just returns (-1,-1). I would suggest raising a ValueError instead (as is already the case when trying a random XML file, since is is parsed as SVG).

On the other hand, that would be a behavior change, so maybe either document the current behavior or bump the major version if this change is implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant