SJIP 18: Remove the question about hardcoded values

[WangSecurity]

Description

Remove the question about hardcoded values from contest README.

Judging Guidelines PR

https://github.com/sherlock-protocol/sherlock-v2-docs/pull/43/files

Rationale

I don't remember a case when it had any value to the contest. Most of the time it's "No", but when it's anything else, the team only states "This variable will/may be changed" and I don't see how it impacts anything.
Additionally, the new questions where protocols can list all the deployment variables if they want overrides this question.

Relevant Issue Discussions

No discussions on any contests. The decision is based on the analysis of many contests' Q&As.

[Czar102]

This question was added because some codebases have hardcoded values and the developers intend to change them from deployment to deployment, but Watsons may be unaware of these plans. For example, there could be a variable uint constant CHAIN_ID = 1; and if the team wants to deploy on both Polygon and Ethereum, is it a mistake? It's not that clear in all situations, so this is a place for teams to explain their plans.

[IllIllI000]

If it were a mutable variable, I'd agree that there's no use for the answer, because they answered 'No'. However, since it's a constant, that question may not neatly apply. Perhaps the 'No' question could be expanded to have something like, "If you plan to change any constants/deployment fields, please include those in your list of limitations."

[WangSecurity]

What about to change the following line:

"This question applies to all access-restricted functions in the codebase, including out-of-scope contracts. Access-restricted functions are only callable by a protocol role (Owner, Keeper, FeeManager, or any custom role specified in the codebase).

To something like this:

"This question applies to all access-restricted functions in the codebase, including out-of-scope contracts. Access-restricted functions are only callable by a protocol role (Owner, Keeper, FeeManager, or any custom role specified in the codebase). Also, list any hardcoded values that you plan to change

[IllIllI000]

This question also applies to any hardcoded values that you plan to change. since we want the possible values, not just the list of variable names.

[WangSecurity]

Also, list any hardcoded variables that you plan to change and the values you plan to apply does it work or still unclear?

[WangSecurity]

Updated.